Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will there be a release? #549

Closed
thejpster opened this issue Dec 18, 2021 · 2 comments
Closed

Will there be a release? #549

thejpster opened this issue Dec 18, 2021 · 2 comments

Comments

@thejpster
Copy link

thejpster commented Dec 18, 2021

Someone has added embassy support to rp-hal for the Raspberry Silicon RP2040. I'd like to publish a new version of that package, but we can't whilst we point at a git dependency for embassy-traits.

Will there be a release soon? If not, I will have to back out support for embassy so I can cargo publish.

Thanks!

@Dirbaio
Copy link
Member

Dirbaio commented Dec 18, 2021

The goal is to make a release eventually, obviously :)

The embassy-traits stuff is quite up in the air since it will probably be replaced by this soon rust-embedded/embedded-hal#285, so we don't want to make a release to have to immediately break it (and break dependents like rp-rs).

For now I'd just comment out the embassy-trait dep in crates.io releases. You also might want to expose async functionality via inherent methods instead of trait methods, so they can be used without embassy-traits, and on stable.

@Dirbaio
Copy link
Member

Dirbaio commented Feb 13, 2022

Closing, the requested crate embassy-traits is now deprecated and almost-deleted. Async traits are now being developed in embedded-hal: rust-embedded/embedded-hal#356

@Dirbaio Dirbaio closed this as completed Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants