Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.13 to CI matrix #81

Merged
merged 1 commit into from Apr 21, 2022
Merged

Conversation

fastjames
Copy link
Contributor

@fastjames fastjames commented Apr 21, 2022

In order to keep up with newer elixir / OTP versions, add 1.13 to the
test matrix (and a few dependency updates to make the new version pass).

Closes #80 .

@fastjames fastjames marked this pull request as ready for review April 21, 2022 21:00
@josevalim
Copy link
Member

It may be that updating some dependencies will make earlier Erlang/OTP versions crash.

@josevalim josevalim closed this Apr 21, 2022
@josevalim josevalim reopened this Apr 21, 2022
@fastjames
Copy link
Contributor Author

It may be that updating some dependencies will make earlier Erlang/OTP versions crash.

The CI failure supports your hypothesis. :-D I will see if I can find a balance point where all the versions can coexist.

@josevalim
Copy link
Member

Bumping OTP version on Elixir 1.7 may be enough. 21 or 22.

In order to keep up with newer elixir / OTP versions, add 1.13 to the
test matrix (and a few dependency updates to make the new version pass).
@fastjames
Copy link
Contributor Author

Bumping OTP version on Elixir 1.7 may be enough. 21 or 22.

Thanks for the suggestion -- it worked in my local testing, so I pushed a change to the OTP version.

@josevalim josevalim merged commit c0dedb7 into elixir-plug:master Apr 21, 2022
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@fastjames fastjames deleted the elixir_1_13_otp24 branch July 27, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mix test errors in Elixir 1.13.3 and Erlang/OTP 24.2.2
2 participants