Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FunctionClauseError when closing a conn in state :handshaking #392

Closed
mruoss opened this issue Mar 2, 2023 · 2 comments
Closed

FunctionClauseError when closing a conn in state :handshaking #392

mruoss opened this issue Mar 2, 2023 · 2 comments
Labels
Kind:Bug

Comments

@mruoss
Copy link
Contributor

mruoss commented Mar 2, 2023

In certain cases I close a connection i have just opened. The connection is still in state :handshaking which makes Mint.HTTP2.close/1 crash with a FunctionClauseError. Is this expected behaviour?
@whatyouhide
Copy link
Contributor

Good catch, definitely not intentional. Fixed, thanks @mruoss! 💟

@whatyouhide whatyouhide changed the title FunctionClauseError when closing a conn in state 🤝 FunctionClauseError when closing a conn in state :handshaking Mar 3, 2023
@whatyouhide
Copy link
Contributor

I released v1.5.1, which includes a fix for this. Thanks for the report @mruoss 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Kind:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mruoss @whatyouhide