Firefox H2 print rendering fix #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey hey!
Couldn't let this ship tomorrow without at least giving Firefox a look!
The markup looks fine so I can't quite give a good answer to why Firefox print renderer brings the H2's border down into the H3 in that one instance, but by using a
:beforepseudo element to add the border we remove the issue.While I was there, I cleaned up the removal of the Print/Settings/View Source icons as two of them still rendered on print.
Additionally, I collapsed the borders on the code elements so there wouldn't be a double thick line when two code elements followed each other.
Firefox Fixes.pdf
Firefox Print Rendering Oddity
When Firefox renders a PDF it handles
font-weight: 700oddly and effectively just doubles the text and shifts it slightly?Looks fine when you print from Firefox, but when you zoom in, bold text in the saved PDF looks quite weird.
I've removed the
font-weight: boldfrom thetdwhich fixes this and looks to be more correct, but thought I should document this rendering oddity.