Distinguish output code blocks #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Sep 20, 2022
| code_attrs = Enum.reject(code_attrs, &match?({"class", _}, &1)) | ||
| new_code = {"code", [{"class", "output"} | code_attrs], [source], code_meta} | ||
| fixup_list([{"pre", pre_attrs, [new_code], pre_meta} | ast], acc) | ||
| end |
There was a problem hiding this comment.
I'm not sure if the Livebook matching shouldn't happen somewhere upstream, but here we reject all comments, so it is the only place given the current approach.
|
@josevalim updated and added a test :)
|
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering notebook contents with outputs, it is not obvious which blocks are outputs, especially that they are highlighted as regular code. This adds a specialized styling for output blocks.