Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readable yellow color for Dark mod #1609

Merged
merged 2 commits into from Sep 18, 2022
Merged

Readable yellow color for Dark mod #1609

merged 2 commits into from Sep 18, 2022

Conversation

shahryarjb
Copy link
Contributor

@shahryarjb shahryarjb commented Sep 18, 2022

Hi, I think this color for yellow color can be warmer and readable in both dark mod and light mod

Before changing

As you see, we can't read the text in dark mod
1
2


After changing

3
4

Changing the color and format is based on the taste of each person.
I did not separate the colors because a variable was created only for the color yellow.

@josevalim
Copy link
Member

Hi @shahryarjb!

We don't need to use the same color for both. We can keep the light theme as is, and update the dark mode only. Can you please amend?

Thank you!

@shahryarjb
Copy link
Contributor Author

shahryarjb commented Sep 18, 2022

Hello sir @josevalim,
I added a new color and set it for dark mod. I prefer not to change the other yellow colors, because they are used in another files, and maybe we have conflict, so I think it is better to add new color as yellowDark

Please see the new changes and If you have any suggestion please let me know I can do it immediately.

Screen Shot 2022-09-18 at 16 11 20
Screen Shot 2022-09-18 at 16 11 30

@josevalim josevalim merged commit 4878b4a into elixir-lang:main Sep 18, 2022
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants