Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve admonition block example #1580

Merged

Conversation

timothyvanderaerden
Copy link
Contributor

No description provided.

@cw789
Copy link
Contributor

cw789 commented Jun 25, 2022

I think the example is correct as it already is.
It just describes changing the class name only.

But I also had to like twice as I first saw the example as it is right now.

Probably we should write something like the following above:

- For example, if you change the class name to `neutral`, you get:
+ For example, if you change the class name to `neutral`, you get the same admonition block in neutral style:

@timothyvanderaerden
Copy link
Contributor Author

That makes sense! I will change the PR with the suggested changes, it makes the example more clear.

@timothyvanderaerden timothyvanderaerden changed the title Fix admonition block example Improve admonition block example Jun 25, 2022
@josevalim josevalim merged commit f0bf412 into elixir-lang:main Jun 25, 2022
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants