Accessibility: Restructure headings #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only holds the title inside the heading, Everything else, such as links are moved our of the heading. Everything is contained in a <div class="section-heading"> tag.
|
It is really hard to make it look the same due to collapsing margins in CSS that now since the heading goes inside a |
|
@eksperimental which part doesn't look the same? At least in the screenshots they look equivalent? :) |
The look very similar but to exactly the same. It is just the gap above and bellow the headings. Save in your computer original and fixed, and alternate the view. You will see the difference. |
|
💚 💙 💜 💛 ❤️ |
josevalim
added a commit
that referenced
this pull request
Sep 13, 2020
This reverts commit 8232103.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only holds the title inside the heading,
Everything else, such as links are moved our of the heading.
Everything is contained in a
<div class="section-heading">tag.A) original**
A) fixed**
B) original
B) fixed
C) original
C) fixed
D) original
D) fixed
E) original
E) fixed
