Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat Application (version number) #1261

Merged

Conversation

eksperimental
Copy link
Contributor

Previously the version number would be before Application name.
This affects the readability in screen readers

Additionally the version number in the sidebar is no longer a heading.

@josevalim
Copy link
Member

@eksperimental does it change how the docs page look like in any way? Or is the visibility the same?

@eksperimental
Copy link
Contributor Author

@eksperimental does it change how the docs page look like in any way? Or is the visibility the same?

It doesn't (well, it shouldn't) but I found a bug, because I am rebasing from the big PR..

I will submit a fix and screenshots for completeness

@eksperimental
Copy link
Contributor Author

This is how the Heading structure and the h1 title looks like now.

Before
app_vsn_before

After
app_vsn_after

Previously the version number would be before Application name.
This affects the readability in screen readers

Additionally the version number in the sidebar is no longer a heading.
@eksperimental
Copy link
Contributor Author

@eksperimental does it change how the docs page look like in any way? Or is the visibility the same?

They look exactly the same. So no need for screenshots

@josevalim josevalim merged commit 0f75903 into elixir-lang:master Aug 26, 2020
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@eksperimental eksperimental deleted the accessibility_app_vsn branch August 26, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants