Make Exceptions a sub-grouping inside modules #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jan 30, 2020
| function getSortingPriority (item) { | ||
| if (isException(item)) { | ||
| return sortingPriority['Exception'] | ||
| } |
There was a problem hiding this comment.
I am thinking we should remove this and not special case Exceptions in any way. Thoughts?
|
💚 💙 💜 💛 ❤️ |
|
Hi @archdragon! I have dropped a comment that we can tackle later if you think it makes sense. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1104
Changes
Exceptionssidebar category was removedModules. This group is always displayed at the last position.API Referencelooks more cluttered now, since exceptions are treated as regular modules and displayed in the module list. We've discussed potentially introducing module grouping there (as a separate PR), to keep the list clean and readable.Demo
[Elixir docs with new exception grouping]