Add write_reference_line_numbers option
#322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johantell
force-pushed
the
allow_pruning_of_line_numbers
branch
from
2d8b661
to
d13f8d2
Compare
Background: Since even the smallest changes in files can cause a cascade of changed line numbers in po/pot files we're often seeing larger amounts of changes in commits causing the need to re-extract than needed. By adding the `write_reference_line_numbers` option developers has a way to decide for themselves whether they want to include them or not. Fixes elixir-gettext#321
johantell
force-pushed
the
allow_pruning_of_line_numbers
branch
from
d13f8d2
to
c7ce1c1
Compare
josevalim
approved these changes
Oct 7, 2022
johantell
commented
Oct 7, 2022
maennchen
reviewed
Oct 7, 2022
maennchen
approved these changes
Oct 8, 2022
szymon-jez
reviewed
Oct 19, 2022
Co-authored-by: Szymon Jeż <35540+szymon-jez@users.noreply.github.com>
|
💚 💙 💜 💛 ❤️ |
ravensiris
pushed a commit
to ravensiris/gettext
that referenced
this pull request
Aug 3, 2023
Background: Since even the smallest changes in files can cause a cascade of changed line numbers in po/pot files we're often seeing larger amounts of changes in commits causing the need to re-extract than needed. By adding the `write_reference_line_numbers` option developers has a way to decide for themselves whether they want to include them or not. Fixes elixir-gettext#321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Since even the smallest changes in files can cause a cascade of changed line numbers in po/pot files we're often seeing larger amounts of changes in commits causing the need to re-extract than needed.
By adding the
write_reference_line_numbersoption developers has a way to decide for themselves whether they want to include them or not.Fixes #321