Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid type error after failover #555

Merged

Conversation

chaodhib
Copy link
Contributor

@chaodhib chaodhib commented Jun 23, 2021

This PR fixes #550

The change to recv_parse_describe ensures that in case the Protocol & Query's types differ, the Query gets a new ref (to trigger an update to the Ecto cache) and gets the Protocol's types (both of these are done in describe_result/4).

Todo:

  • Maybe the same change should be done for the streaming of a prepared query?

@josevalim
Copy link
Member

Maybe the same change should be done for the streaming of a prepared query?

I will review this soon but I just want to say the answer to this question is yes. :)

@chaodhib
Copy link
Contributor Author

chaodhib commented Jun 23, 2021

Maybe the same change should be done for the streaming of a prepared query?

I will review this soon but I just want to say the answer to this question is yes. :)

ok will do :)

EDIT: done!

@josevalim josevalim merged commit a849473 into elixir-ecto:master Jun 24, 2021
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@chaodhib chaodhib deleted the fix_invalid_type_error_after_failover branch June 24, 2021 13:15
josevalim pushed a commit that referenced this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'invalid types for the connection' error after a DB fail over
2 participants