Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #443

Merged
merged 2 commits into from Oct 18, 2021
Merged

Fix typos #443

merged 2 commits into from Oct 18, 2021

Conversation

kianmeng
Copy link
Contributor

No description provided.

Copy link
Owner

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left a couple of comments to fix. Otherwise LGTM and I'll merge it once fixed

@@ -32,7 +32,7 @@
# -----------------------------------------------------------------------------
#
# This implements an LR parser that is constructed from grammar rules defined
# as Python functions. The grammer is specified by supplying the BNF inside
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes in the ply/ directory - it's a vendored dependency and I don't want any changes in there

@@ -3652,7 +3652,7 @@ struct Btree {
sqlite3 *db;
BtShared *pBt;
u8 inTrans;
u8 sharable;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this file too - it's vendored in

@kianmeng
Copy link
Contributor Author

Thanks, I left a couple of comments to fix. Otherwise LGTM and I'll merge it once fixed

Done. Please check.

@kianmeng kianmeng requested a review from eliben October 17, 2021 16:53
@eliben eliben merged commit a7b480c into eliben:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants