Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release pycparser v2.21 #438

Closed
eliben opened this issue Oct 4, 2021 · 7 comments
Closed

Release pycparser v2.21 #438

eliben opened this issue Oct 4, 2021 · 7 comments

Comments

@eliben
Copy link
Owner

eliben commented Oct 4, 2021

The previous release (2.20) was quite a while ago (Mar 2020). Lots of changes has accumulated since.

@vit9696 are you planning additional significant C11 work any time soon?

I'd be happy to get help testing before a new release is made.

@vit9696
Copy link
Contributor

vit9696 commented Oct 4, 2021

Hi @eliben, I actually wanted to ask you for a release myself :)

To be fair, I wanted to perform a few more tests of pycparser on a certain codebase before that happens in case we missed something non-trivial. I am also relatively concerned about #433 as it may cause very serious with generation, which we rely on to generate function wrappers for testing, but at this step I do not have a good suggestion. It will be nice if you can wait by the end of the week, and release then if I keep silent.

In general I have no plans to add new features soon. The remaining C11 features that would possibly require pycparser updates are:

Feel free to mention anything that I missed. I do not think I personally need any of these, but it would be nice to have full C11 compatibility in pycparser eventually in the future.

@eliben
Copy link
Owner Author

eliben commented Oct 4, 2021

I'm fine with waiting, there's no rush to release whatsoever. The additional testing you're mentioning is precisely the kind of vetting I would hope will happen before I make a new release.

This is also a call to everyone who's only running/testing their stuff with a released version -- please run/test it with the tip of master branch and report any serious issues, and in particular regressions.

@vit9696
Copy link
Contributor

vit9696 commented Oct 4, 2021

Our stuff seems to be working fine, but I actually ended up adding unicode string support just in case we need it in #439. Anonymous structures already are supported by pycparser, and as for _Imaginary_I or _Complex_I these would rather need preprocessor stuff than actual pycparser support.

This leaves us just with the _Generics, but I am really not into it. It is messy and has little use in real world from my own perspective. I guess you can update the README to say that C18 is mostly supported aside _Generic with some features from C23.

@eliben eliben pinned this issue Oct 5, 2021
@vit9696
Copy link
Contributor

vit9696 commented Oct 12, 2021

Thanks for the delay, I think it is all good on our side.

eliben added a commit that referenced this issue Nov 6, 2021
@eliben
Copy link
Owner Author

eliben commented Nov 6, 2021

v2.21 has been release to PyPI: https://pypi.org/project/pycparser/2.21/
And tagged on GitHub.

Marking the issue fixed; please reopen if you observe problems.

@eliben eliben closed this as completed Nov 6, 2021
@johnernberg
Copy link

The added argument align to the c_ast Decl object constructor breaks the API between 2.20 and 2.21, was that intended?

@eliben
Copy link
Owner Author

eliben commented Nov 10, 2021

The added argument align to the c_ast Decl object constructor breaks the API between 2.20 and 2.21, was that intended?

Can you clarify in what way the API is broken, with an example? It'd be best to open a new issue for this.

Generally, though, it's hard to add features without adding fields on the AST nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants