Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #378, #379, #385 #387

Merged
merged 3 commits into from Jul 18, 2020
Merged

Fix issues #378, #379, #385 #387

merged 3 commits into from Jul 18, 2020

Conversation

huzecong
Copy link
Contributor

This PR address the following issues:

New test cases are added to cover the changes.

Only the assertion inside `_build_function_definition` is replaced. The
assertion is not appropriate because there are possible inputs that
would trigger the assertion, they're just grammatically incorrect. Thus,
it is replaced with a check that raises `ParseError` on failure.
Copy link
Owner

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.

A note for the future: it'd be better to send one PR per issue - makes it easier to review and discuss.

@eliben eliben merged commit 6da5009 into eliben:master Jul 18, 2020
@huzecong huzecong deleted the bug-fix branch July 18, 2020 15:42
@huzecong
Copy link
Contributor Author

Got it, will do that in the future!

tomoguara added a commit to tomoguara/pycparser that referenced this pull request Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants