Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the following issues:
ParseError
s #378: Replace assertion insideCParser
with check that raisesParseError
on failure.What's changed: Only the assertion inside
_build_function_definition
is replaced. The assertion is not appropriate because there are possible inputs (although grammatically incorrect) that would trigger the assertion.AttributeError
when parsingstruct
with nestedenum
#379: Fix exception when parsingstruct
with nestedenum
.What's changed:
Enum
is also added to the list of node types that are handled differently insideCParser._build_declarations
(the others beingStruct
,Union
, andIdentifierType
).sizeof
s. #385: Fix exponential time cost when generating code with nestedsizeof
s.What's changed: Simple fix in
CGenerator
.New test cases are added to cover the changes.