Fix error transforming an empty switch #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser would crash on that line for `switch(1) {}`
because NoneType is not iterable.
Fixes eliben#345
eliben
requested changes
Aug 21, 2019
|
Done, asserted that the new block_items were |
eliben
requested changes
Aug 21, 2019
tests/test_c_parser.py
Outdated
| @@ -1799,6 +1799,7 @@ def assert_default_node(node): | |||
| assert_case_node(block[2], '30') | |||
| self.assertEqual(len(block[2].stmts), 1) | |||
| assert_default_node(block[3]) | |||
| self.assertEqual(len(block), 4) | |||
There was a problem hiding this comment.
Could you please move this test to before the assertions on block[...] begin?
tests/test_c_parser.py
Outdated
| switch = ps3.ext[0].body.block_items[0] | ||
|
|
||
| block = switch.stmt.block_items | ||
| self.assertEqual(block, []) |
There was a problem hiding this comment.
Nit: block is unnecessary here, just assert on switch.stmt.block_items
eliben
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser would throw on that line for
switch(1) {}because NoneType is not iterable.
Fixes #345