Fix crash when file starts with a semicolon #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliben
requested changes
Mar 6, 2019
tests/test_c_parser.py
Outdated
| @@ -128,7 +128,7 @@ def test_FileAST(self): | |||
| self.assertEqual(len(t2.ext), 0) | |||
|
|
|||
| def test_empty_toplevel_decl(self): | |||
| code = 'int foo;;' | |||
| code = ';int foo;;' | |||
There was a problem hiding this comment.
Please add this as a separate test
tests/test_c_parser.py
Outdated
| @@ -800,7 +800,7 @@ def test_struct_union(self): | |||
| def test_struct_with_extra_semis_inside(self): | |||
| s1 = """ | |||
| struct { | |||
| int a;; | |||
| ;int a;; | |||
simonlindholm
force-pushed
the
fix-initial-semi-crash
branch
from
af8c6ac
to
8fc3667
Compare
simonlindholm
force-pushed
the
fix-initial-semi-crash
branch
from
8fc3667
to
16e82c3
Compare
|
Updated. |
eliben
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.