-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Parsing of Floating Point Literals #253
Comments
Good point! Feel free to submit a PR |
eliben
pushed a commit
that referenced
this issue
Aug 31, 2018
* Corrects the type attribute of a constant node when parsing doubles. This sets the type attribute to either 'float', 'long double' or 'double' depending on if 'f|F', 'l|L' or '' is specified at the end of the constant definition. * Add tests for previous changes.
Fixed by #277 |
Thanks for properly naming the commits/PR @robbert-harms, it made it much easier to find what caused my compiler to break upon installing on another machine (and therefore getting a new version of pycparser)! |
It seems that the case for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the floating point literal
is parsed to
when really, the
type
attribute of theConstant
node should be "double". Likewise,is parsed to
when the
type
attribute of theConstant
node should be "long double". Note that the declared type is not what matters, it is the parsing of the floating point literal.The text was updated successfully, but these errors were encountered: