Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for #pragma in struct_declaration (Issue #221). #222

Merged
merged 2 commits into from Nov 22, 2017
Merged

Add support for #pragma in struct_declaration (Issue #221). #222

merged 2 commits into from Nov 22, 2017

Conversation

ldore
Copy link
Contributor

@ldore ldore commented Nov 22, 2017

Support #pragma within a struct

Note: On first run (when lextab.py/yacctab.py do not exist yet), I get the following message:

Generating LALR tables
WARNING: 1 shift/reduce conflict

As this also happens on master, I assume this is OK.

eliben
eliben requested changes Nov 22, 2017
View reviewed changes
Copy link
Owner

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a parser test (in test_c_parser) to check that the pragma gets parsed and we get a Pragma node?

@eliben eliben merged commit ec23318 into eliben:master Nov 22, 2017
@eliben
Copy link
Owner

eliben commented Nov 22, 2017

Merging, thanks!

@myint myint mentioned this pull request Apr 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliben eliben eliben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ldore @eliben