Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ply to 3.8 #121

Merged
merged 1 commit into from Apr 19, 2016
Merged

Upgrade ply to 3.8 #121

merged 1 commit into from Apr 19, 2016

Conversation

doctaphred
Copy link
Contributor

Got bitten by a bug today that's fixed in ply 3.6, so I figured I'd share the fix, which is just upgrading the bundled version of ply.

Travis builds succeeded, but I confess I couldn't get one test to pass on my machine (OS X, Python 2.7), either before or after the changes. Stack trace is below in case you're curious, but it's a separate issue. Let me know if you want more information, but otherwise I won't worry about it.

Let me know if I can do anything else to help. I'm new to open source, so apologies for any rookie mistakes. Cheers, and thanks for the great work!

ERROR: test_with_cpp (test_general.TestParsing)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/fwagner/dev/pycparser/tests/test_general.py", line 31, in test_with_cpp
    cpp_args='-I%s' % c_files_path)
  File "./pycparser/__init__.py", line 94, in parse_file
    return parser.parse(text, filename)
  File "./pycparser/c_parser.py", line 147, in parse
    debug=debuglevel)
  File "./pycparser/ply/yacc.py", line 265, in parse
    return self.parseopt_notrack(input,lexer,debug,tracking,tokenfunc)
  File "./pycparser/ply/yacc.py", line 1047, in parseopt_notrack
    tok = self.errorfunc(errtoken)
  File "./pycparser/c_parser.py", line 1700, in p_error
    column=self.clex.find_tok_column(p)))
  File "./pycparser/plyparser.py", line 55, in _parse_error
    raise ParseError("%s: %s" % (coord, msg))
ParseError: /Users/fwagner/dev/pycparser/tests/c_files/memmgr.c:1:1: before: /

@@ -1,4 +1,5 @@
# PLY package
# Author: David Beazley (dave@dabeaz.com)

__version__ = '3.7'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this still says 3.7, but it's legit: https://github.com/dabeaz/ply/blob/master/ply/__init__.py#L4

@eliben
Copy link
Owner

eliben commented Apr 17, 2016

Thanks, couple of questions/requests:

  • Please update the README.rst of pycparser which mentions PLY's version
  • Can you specify somewhere (maybe in the README) where you downloaded PLY exactly (link) - because of the version confusion
  • Finally once all's done, please squash the PR to a single commit so I can merge

The new version includes some bugfixes that affect downstream projects.
@doctaphred
Copy link
Contributor Author

Done! How does this look?

@eliben eliben merged commit 4d304cc into eliben:master Apr 19, 2016
@eliben
Copy link
Owner

eliben commented Apr 19, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants