Line numbers set to 0

[MathieuChailloux]

Hi,

First of all, thanks for the work done over here.
I've noticed that field .coord.line is systematically set to 0 for nodes of classes Compound and EmptyStatement (and maybe some others).

For instance, considering below file toto.c :

void f() {
  if (1) {
    ;
  } else {
    return;
  }
}

Pycparser give me this :

>>> import pycparser
>>> ast = pycparser.parse_file("toto.c")
>>> ast.show(showcoord=True)
FileAST:  (at None)
  FuncDef:  (at toto.c:1)
    Decl: f, [], [], [] (at toto.c:1)
      FuncDecl:  (at toto.c:1)
        TypeDecl: f, [] (at toto.c:1)
          IdentifierType: ['void'] (at toto.c:1)
    Compound:  (at toto.c:0)
      If:  (at toto.c:2)
        Constant: int, 1 (at toto.c:2)
        Compound:  (at toto.c:0)
          EmptyStatement:  (at toto.c:0)
        Compound:  (at toto.c:0)
          Return:  (at toto.c:5)

Is this an implementation choice, a known issue, a new one ?

Regards

[eliben]

Seems fairly arbitrary to me, since these nodes don't really have a concrete source representation

[MathieuChailloux]

Well, I haven't explored deeply the grammar used for parsing but i guess an EmptyStatement is built when meeting a line containing a lonely ;, so to me it does have a concrete source representation and an associated line.

For Compound nodes, i guess they match opening and closing braces.
For instance, considering below files "toto3.c" and "toto4.c"

toto3.c

void f() {
  while(1)
    ;
}

toto4.c

void f() {
  while(1) {
    ;
  }
}

Pycparser gives me this

>>> ast3 = pycparser.parse_file("toto3.c")
>>> ast3.show(showcoord=True)
FileAST:  (at None)
  FuncDef:  (at toto3.c:1)
    Decl: f, [], [], [] (at toto3.c:1)
      FuncDecl:  (at toto3.c:1)
        TypeDecl: f, [] (at toto3.c:1)
          IdentifierType: ['void'] (at toto3.c:1)
    Compound:  (at toto3.c:0)
      While:  (at toto3.c:2)
        Constant: int, 1 (at toto3.c:2)
        EmptyStatement:  (at toto3.c:0)
>>> ast4 = pycparser.parse_file("toto4.c")
>>> ast4.show(showcoord=True)
FileAST:  (at None)
  FuncDef:  (at toto4.c:1)
    Decl: f, [], [], [] (at toto4.c:1)
      FuncDecl:  (at toto4.c:1)
        TypeDecl: f, [] (at toto4.c:1)
          IdentifierType: ['void'] (at toto4.c:1)
    Compound:  (at toto4.c:0)
      While:  (at toto4.c:2)
        Constant: int, 1 (at toto4.c:2)
        Compound:  (at toto4.c:0)
          EmptyStatement:  (at toto4.c:0)

That would lead me to think that they indeed match braces.

So I don't really see your point but maybe have I missed something.

Regards

[eliben]

That sounds reasonable. Feel free to submit a PR and we can talk over the concrete details there

[guivigon]

Hi

sorry for asking again about this. It might be resolved and I'm not aware. Is this issue fixed? I'm interested on getting this functionality working...

Thanks.

Regards

[eliben]

@guivigon Not that I know of

[eliben]

I believe this should be fixed int the master branch now. Please LMK if you see additional issues.