added support for Pragma #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I'm fine with including pragmas in the AST, as long as the change is conservative - i.e. doesn't break other code and if we encounter pragmas we can tokenize but not parse yet it shouldn't fail (similarly to the way it's done now). |
|
I added and modified the unit test accordingly. Any other requests? |
| @@ -795,3 +795,15 @@ def children(self): | |||
|
|
|||
| attr_names = () | |||
|
|
|||
| class Pragma(Node): | |||
There was a problem hiding this comment.
You are not supposed to modify this file directly. It's auto generated
There was a problem hiding this comment.
Yes, I forgot to add the changed _c_ast.cfg file to the commit. Added in 95ee04f
|
Anything else missing? |
|
Looks good. Please squash into a single commit and put as much info as possible into the commit message; then it's good to go. |
Preprocessor pragmas and their arguments are tokenized (as PPPRAGMA and PPPRAGMASTR) and included in the AST as a pppragma directive with the argument as value. If no argument was given the string will be empty. Unit test of the lexer, parser and generator have been modified and added accordingly. The previous behavior, that #pragma lines would be ignored, is henceforth obsolete.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there any chance to include (optional) support for #pragma in the AST? I know it is not strictly C99, since it is supposed to be handled before and not through the AST.
Dirty patch included, just as an example.