Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not all punycode-encoded domains work #8991

Open
matrixbot opened this issue Dec 18, 2023 · 0 comments
Open

not all punycode-encoded domains work #8991

matrixbot opened this issue Dec 18, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 18, 2023

This issue has been migrated from #8991.


Description

If you have a domain with only emoji and want to set your server_name to the punycode-encoded versoin of it (e.g. xn--9s9hnf.ws) the server is not able to federate.

This is because twisted.web.client uses the python package idna over here to check if a domain is valid. Editing that to use text.encode("idna") and text.decode("idna") fixes this issue.

Said idna package has an issue here about not supporting emoji domains, and from the sounds of it they do not plan to add it.

Soru would open this issue with the twisted package, but she couldn't find any way to open non-security-critical bug reports with them. This issue also affects synapse as, well, that does not allow you to have all punycode-encoded domains as your server_name, even though they are valid according to the spec etc.

@matrixbot matrixbot changed the title Dummy issue not all punycode-encoded domains work Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant