Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publisher-ers): properly publish non-default flavours #3079

Merged
merged 1 commit into from Nov 30, 2022

Conversation

dariusclay
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

  • post request form data for version now uses flavor value
  • also including auto channel selection for 'rc' versions

also including auto channel selection for 'rc' versions
@erickzhao erickzhao changed the title fix issue in publisher-electron-release-server when specifying other flavors than default fix(publisher-ers): properly publish non-default flavours Nov 16, 2022
@erickzhao
Copy link
Member

oops that's my bad, I failed to properly implement the feature in #2766

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dariusclay I'm happy to merge this as-is, but I'm wondering if there are any improvements to be made to the tests in accordance to this PR!

@dariusclay
Copy link
Contributor Author

For sure, I will check the test cases and see what I can do. Thanks

@erickzhao erickzhao merged commit d4a51de into electron:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants