Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(test): remove unnecessary coverage artifacts #3066

Merged
merged 1 commit into from Nov 13, 2022
Merged

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Nov 10, 2022

Follow-up to #3044, this PR removes the Istanbul code coverage tool from our test commands, and de-duplicates the coverage and test commands.

Note
There was a discrepancy in how coverage and test ran fast vs. slow tests.

  • coverage ran fast tests with the INTEGRATION_TESTS=0 env var, which specifically disabled the tests/slow/api_spec_slow.ts file.
  • test ran fast tests with the TEST_FAST_ONLY env var, which skips any tests that don't end with spec.ts.

I'm not aware of the historical context behind the two flags but it seemed inconsistent to me. I ended up keeping the TEST_FAST_ONLY env var in this PR and removing the other one.

@erickzhao erickzhao requested a review from a team November 10, 2022 22:26
@MarshallOfSound MarshallOfSound merged commit 75462be into main Nov 13, 2022
@MarshallOfSound MarshallOfSound deleted the uncovered branch November 13, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants