Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add husky pre-push script #3061

Merged
merged 5 commits into from Nov 21, 2022
Merged

chore: add husky pre-push script #3061

merged 5 commits into from Nov 21, 2022

Conversation

georgexu99
Copy link
Contributor

@georgexu99 georgexu99 commented Nov 9, 2022

This PR adds a pre-push hook to provide a warning if the user attempts to push to main

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@georgexu99 georgexu99 force-pushed the gxu-husky branch 2 times, most recently from 45e5077 to bf4767a Compare November 9, 2022 21:40
@georgexu99 georgexu99 marked this pull request as ready for review November 10, 2022 20:37
@georgexu99 georgexu99 changed the title chore: add husky pre-push script chore(WIP): add husky pre-push script Nov 10, 2022
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just make this a node script and use inquirer instead? It's already in our dependency tree and works on windows

@erickzhao erickzhao marked this pull request as draft November 14, 2022 17:35
@georgexu99 georgexu99 marked this pull request as ready for review November 14, 2022 22:55
@georgexu99 georgexu99 requested review from MarshallOfSound and a team November 14, 2022 22:55
@georgexu99 georgexu99 changed the title chore(WIP): add husky pre-push script chore: add husky pre-push script Nov 15, 2022
.husky/pre-push.js Outdated Show resolved Hide resolved
.husky/pre-push.js Show resolved Hide resolved
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM. Ready to merge after conflicts are fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants