Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate to lerna from bolt #3058

Merged
merged 16 commits into from Nov 14, 2022
Merged

build: migrate to lerna from bolt #3058

merged 16 commits into from Nov 14, 2022

Conversation

georgexu99
Copy link
Contributor

@georgexu99 georgexu99 commented Nov 8, 2022

This PR changes the monorepo package management tool to Lerna from Bolt. Lerna also works with yarn workspaces and nx so we use those as well. This gives us several benefits, including but not limited to:

cached tests !!! (nx);
dependency hoisting and symlinking (yarn workspaces);
a newer version of package management tool (bolt version was very old), and,
the ability to leverage lerna version and lerna publish, replacing our old version bump and publish scripts.
NOTE: this PR may be easier to review going commit by commit

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #3072

@VerteDinde VerteDinde self-requested a review November 9, 2022 00:33
lerna.json Outdated Show resolved Hide resolved
lerna.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing this work! 👏 Tested on Windows and the linking is working great. Let's cut a new release of Forge shortly after this is merged, just to double verify all of the publishing steps work as expected.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@erickzhao erickzhao changed the title Refactor: migrate to lerna from bolt build: migrate to lerna from bolt Nov 9, 2022
@juristr
Copy link

juristr commented Nov 10, 2022

Hey, Juri from the Nx/Lerna core team here 👋
great to see Lerna being upgraded here 😃. If you need any help/input from our side, feel free to reach out!

Since Forge is open source, it would also be eligible for free Nx Coud remote caching. Is that something you're interested in? The main advantage is that caching is not just locally on developer machines, but you can also leverage it on CI & thus, obviously speed up things.
If that sounds interesting, someone from our team can submit a follow-up PR to enable that. It is non-invasive since all that changes is the actual task runner in nx.json. That's it :)

@georgexu99 georgexu99 merged commit f16a28b into main Nov 14, 2022
@georgexu99 georgexu99 deleted the gxu-lerna-migration-4 branch November 14, 2022 19:12
@georgexu99
Copy link
Contributor Author

@juristr

Hi Juri, thank you for the kind offer! It would be great to set up caching on our CI. I would be happy to help with any changes that are needed to enable the feature :)

@juristr
Copy link

juristr commented Nov 15, 2022

@georgexu99 Awesome! Let me have a co-worker of mine push up a PR and we can keep the discussion going based on the required changes :)

@georgexu99
Copy link
Contributor Author

@juristr Hey Juri! Is there anything I can do to help with the PR?

@juristr
Copy link

juristr commented Nov 21, 2022

@georgexu99 I've talked to a co-worker of mine last week. They will send a PR soon :) We can then get the discussion going based on that :)

@AgentEnder
Copy link

@georgexu99 Can you join our community slack so we can talk privately regarding getting the cloud workspace setup under your account? If you have already joined, feel free to DM me on there. My name is Craigory, should see Nx Core Team in it as well. I work with Juri :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run tests with npm versions greater than 6.x
6 participants