refactor: migrate import command to listr2 #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
approved these changes
Nov 4, 2022
Co-authored-by: Erick Zhao <erick@hotmail.ca>
VerteDinde
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Code looks good!
Is there any chance that something else outside of Forge would use async-ora? I was wondering if it would be worth it to throw on a deprecation warning before we outright deleting it - if we're pretty sure nothing's using it though, I'm fine to kill it 🙂
The old versions will keep working, we should probably deprecate it at some point but I don't see a need to right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title, this also allows us to fully delete the
async-orapackage