fix(publish): ignore unnecessary files when publishing to npm #3024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Currently, a large number of source/development files (
.ts
/.map
/etc.) from most packages is being published to npm.The
plugin-webpack
package is even publishing its entiretest
folder with a test app, including itsnode_modules
:This PR addresses the problem by writing a
.npmignore
file to each package folder before publishing, and then removing the file afterwards..ts
(except.d.ts
type definitions),tsconfig.json
,.map
and.tsbuildinfo
files, as well as any/test
folders, are now ignored.Since the
.gitignore
in the project root has.npmignore
, I thought writing and then deleting the files would be an acceptable approach (not to mention easier to review), but actually adding the.npmignore
files to Git would be trivial if necessary.