From 943a67b0f215575cef4cdf7e3b5ae64ee40a65c1 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Mon, 10 Oct 2022 14:49:06 +0000 Subject: [PATCH 1/2] fix: override content::ContentMainDelegate::CreateContentClient() Co-authored-by: Shelley Vohr --- shell/app/electron_main_delegate.cc | 9 ++++++--- shell/app/electron_main_delegate.h | 1 + 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/shell/app/electron_main_delegate.cc b/shell/app/electron_main_delegate.cc index 46a3bcc1d6058..4bdb5f7bbfca9 100644 --- a/shell/app/electron_main_delegate.cc +++ b/shell/app/electron_main_delegate.cc @@ -317,9 +317,6 @@ absl::optional ElectronMainDelegate::BasicStartupComplete() { ::switches::kDisableGpuMemoryBufferCompositorResources); #endif - content_client_ = std::make_unique(); - SetContentClient(content_client_.get()); - return absl::nullopt; } @@ -440,6 +437,12 @@ base::StringPiece ElectronMainDelegate::GetBrowserV8SnapshotFilename() { return ContentMainDelegate::GetBrowserV8SnapshotFilename(); } +content::ContentClient* ElectronMainDelegate::CreateContentClient() { + content_client_ = std::make_unique(); + SetContentClient(content_client_.get()); + return content_client_.get(); +} + content::ContentBrowserClient* ElectronMainDelegate::CreateContentBrowserClient() { browser_client_ = std::make_unique(); diff --git a/shell/app/electron_main_delegate.h b/shell/app/electron_main_delegate.h index 4b51f5ba2a95b..15cff1cc76ce1 100644 --- a/shell/app/electron_main_delegate.h +++ b/shell/app/electron_main_delegate.h @@ -38,6 +38,7 @@ class ElectronMainDelegate : public content::ContentMainDelegate { void PreSandboxStartup() override; void SandboxInitialized(const std::string& process_type) override; absl::optional PreBrowserMain() override; + content::ContentClient* CreateContentClient() override; content::ContentBrowserClient* CreateContentBrowserClient() override; content::ContentGpuClient* CreateContentGpuClient() override; content::ContentRendererClient* CreateContentRendererClient() override; From 7477da48daed6312594c132f5c1de20decf60f9e Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Mon, 10 Oct 2022 14:49:12 +0000 Subject: [PATCH 2/2] chore: remove extra call Co-authored-by: Shelley Vohr --- shell/app/electron_main_delegate.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/shell/app/electron_main_delegate.cc b/shell/app/electron_main_delegate.cc index 4bdb5f7bbfca9..b70ace445c956 100644 --- a/shell/app/electron_main_delegate.cc +++ b/shell/app/electron_main_delegate.cc @@ -439,7 +439,6 @@ base::StringPiece ElectronMainDelegate::GetBrowserV8SnapshotFilename() { content::ContentClient* ElectronMainDelegate::CreateContentClient() { content_client_ = std::make_unique(); - SetContentClient(content_client_.get()); return content_client_.get(); }