Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call loadUrl when opening new windows from links #34910

Merged
merged 1 commit into from Jul 13, 2022
Merged

fix: call loadUrl when opening new windows from links #34910

merged 1 commit into from Jul 13, 2022
+135 −0

Conversation

codebytere
Copy link
Member

Backport of #34159.

See that PR for details.

Notes: Fixes an issue where some BrowserWindows opened from new links wouldn't properly load URLs.

@codebytere codebytere requested a review from a team July 13, 2022 16:52
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 13, 2022
@trop trop bot mentioned this pull request Jul 13, 2022
Merged
4 tasks
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 13, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 13, 2022
@jkleinsc jkleinsc merged commit f06842e into 18-x-y Jul 13, 2022
@jkleinsc jkleinsc deleted the fix-new-window-open-18 branch July 13, 2022 21:17
@release-clerk
Copy link

release-clerk bot commented Jul 13, 2022

Release Notes Persisted

Fixes an issue where some BrowserWindows opened from new links wouldn't properly load URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc