Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iocp integration when process is reused #33363

Merged
merged 1 commit into from Mar 23, 2022

Conversation

deepak1556
Copy link
Member

Description of Change

Backport of #33207

Release Notes

Notes: fix broken event loop in renderer process when process reuse is enabled on windows platform

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 21, 2022
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 21, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 21, 2022
@deepak1556 deepak1556 force-pushed the robo/cherry_pick_33207_16_x_y branch from 8f25662 to 7f0f18d Compare March 21, 2022 13:31
@deepak1556
Copy link
Member Author

Failing macos tests are unrelated and have been failing on the branch in other runs, merging.

@deepak1556 deepak1556 merged commit 45e14a5 into 16-x-y Mar 23, 2022
@deepak1556 deepak1556 deleted the robo/cherry_pick_33207_16_x_y branch March 23, 2022 07:02
@release-clerk
Copy link

release-clerk bot commented Mar 23, 2022

Release Notes Persisted

fix broken event loop in renderer process when process reuse is enabled on windows platform

vikunja-bot pushed a commit to go-vikunja/desktop that referenced this pull request Mar 24, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [electron](https://github.com/electron/electron) | devDependencies | minor | [`17.1.2` -> `17.2.0`](https://renovatebot.com/diffs/npm/electron/17.1.2/17.2.0) |

---

### Release Notes

<details>
<summary>electron/electron</summary>

### [`v17.2.0`](https://github.com/electron/electron/releases/v17.2.0)

[Compare Source](electron/electron@v17.1.2...v17.2.0)

### Release Notes for v17.2.0

#### Features

-   Added `ses.setCodeCachePath()` API for setting code cache directory. [#&#8203;33285](electron/electron#33285) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33286))</span>

#### Fixes

-   Fire 'show' event when a BrowserWindow is shown via maximize(). [#&#8203;33213](electron/electron#33213) <span style="font-size:small;">(Also in [16](electron/electron#33212), [18](https://github.com/electron/electron/pull/33214))</span>
-   Fixed a network service crash that could occur when using setCertificateVerifyProc. [#&#8203;33254](electron/electron#33254) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33253))</span>
-   Fixed an issue where BrowserView layout bounds where limited to it's visible bounds. [#&#8203;33398](electron/electron#33398) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33399))</span>
-   Fixed an issue where Chrome DevTools settings didn't persist between loads. [#&#8203;33273](electron/electron#33273) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33206))</span>
-   Fixed an issue where clicking "Open in Containing Folder" in the Sources tab in Devtools caused a crash. [#&#8203;33196](electron/electron#33196) <span style="font-size:small;">(Also in [16](electron/electron#33313), [18](https://github.com/electron/electron/pull/33197))</span>
-   Fixed broken event loop in renderer process when process reuse is enabled on windows platform. [#&#8203;33362](electron/electron#33362) <span style="font-size:small;">(Also in [16](electron/electron#33363), [18](https://github.com/electron/electron/pull/33361))</span>
-   Fixed crash in the render process on reload with pending node fs.promises. [#&#8203;33335](electron/electron#33335) <span style="font-size:small;">(Also in [15](electron/electron#33300), [16](electron/electron#33301), [18](https://github.com/electron/electron/pull/33302))</span>
-   Fixed drag regions on WCO windows on Windows. [#&#8203;33201](electron/electron#33201) <span style="font-size:small;">(Also in [15](electron/electron#33199), [16](electron/electron#33200), [18](https://github.com/electron/electron/pull/33202))</span>
-   Fixed incorrect external memory allocation tracking in nativeImage module. [#&#8203;33306](electron/electron#33306) <span style="font-size:small;">(Also in [15](electron/electron#33311), [16](electron/electron#33312), [18](https://github.com/electron/electron/pull/33305))</span>
-   Theoretical fix for a crash we're seeing when closing multiple child windows at the same time on macOS. [#&#8203;33283](electron/electron#33283) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33284))</span>

#### Other Changes

-   Fixed an issue where adding/removing display changes the BrowserWindow size. [#&#8203;33251](electron/electron#33251) <span style="font-size:small;">(Also in [14](electron/electron#33247), [15](electron/electron#33248), [16](electron/electron#33249), [18](https://github.com/electron/electron/pull/33250))</span>
-   Fixed an issue where moving a window created in a scaled display to a regular display would increase the window size. [#&#8203;33231](electron/electron#33231)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/83
Co-authored-by: renovate <renovatebot@kolaente.de>
Co-committed-by: renovate <renovatebot@kolaente.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants