Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick 1aa9b09 from chromium #33231

Merged
merged 3 commits into from Mar 22, 2022
Merged

chore: cherry-pick 1aa9b09 from chromium #33231

merged 3 commits into from Mar 22, 2022

Conversation

mlaurencin
Copy link
Contributor

Subject: Set dpi_ correctly during main window creation

For some Chrome windows the dpi_ setting cannot be set during window
creation because the window location is not yet known. For other windows
the dpi_ setting must be set during window creation. This change
handles both cases by setting dpi_ if the window size/location is being
specified. This then handles both the task manager and main window
cases.

Bug: 1282804
Change-Id: Ic85dfb1646e9d063af324cc79736b660cea1acdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3378579
Reviewed-by: Robert Liao robliao@chromium.org
Commit-Queue: Bruce Dawson brucedawson@chromium.org
Cr-Commit-Position: refs/heads/main@{#957715}

Closes #32516

18-x-y and main are both past chromium 99.0.4824.0 and thus have this fix.

Release Notes

Notes: Fixed an issue where moving a window created in a scaled display to a regular display would increase the window size

@mlaurencin mlaurencin requested review from a team as code owners March 10, 2022 23:51
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 10, 2022
@mlaurencin mlaurencin added semver/minor backwards-compatible functionality target/15-x-y labels Mar 14, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 17, 2022
@jkleinsc jkleinsc added the backport-check-skip Skip trop's backport validity checking label Mar 22, 2022
@zcbenz zcbenz merged commit f983099 into 17-x-y Mar 22, 2022
@zcbenz zcbenz deleted the set-dpi_-correctly branch March 22, 2022 07:50
@release-clerk
Copy link

release-clerk bot commented Mar 22, 2022

Release Notes Persisted

Fixed an issue where moving a window created in a scaled display to a regular display would increase the window size

@trop trop bot mentioned this pull request Mar 22, 2022
Closed
trop bot pushed a commit that referenced this pull request Mar 22, 2022
@mlaurencin @jkleinsc
@patchup @electron-bot
chore: cherry-pick 1aa9b09 from chromium (#33231)
e0ce619 
* chore: cherry-pick 1aa9b09 from chromium

* chore: update patches

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
trop bot pushed a commit that referenced this pull request Mar 22, 2022
@mlaurencin @jkleinsc
@patchup @electron-bot
chore: cherry-pick 1aa9b09 from chromium (#33231)
aac3914 
* chore: cherry-pick 1aa9b09 from chromium

* chore: update patches

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
@trop trop bot mentioned this pull request Mar 22, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Mar 22, 2022

I have automatically backported this PR to "15-x-y", please check out #33380

@trop
Copy link
Contributor

trop bot commented Mar 22, 2022

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Mar 22, 2022

I have automatically backported this PR to "16-x-y", please check out #33381

@mlaurencin mlaurencin mentioned this pull request Mar 22, 2022
Closed
3 tasks
vikunja-bot pushed a commit to go-vikunja/desktop that referenced this pull request Mar 24, 2022
@kolaente
chore(deps): update dependency electron to v17.2.0 (#83)
b3029db 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [electron](https://github.com/electron/electron) | devDependencies | minor | [`17.1.2` -> `17.2.0`](https://renovatebot.com/diffs/npm/electron/17.1.2/17.2.0) |

---

### Release Notes

<details>
<summary>electron/electron</summary>

### [`v17.2.0`](https://github.com/electron/electron/releases/v17.2.0)

[Compare Source](electron/electron@v17.1.2...v17.2.0)

### Release Notes for v17.2.0

#### Features

-   Added `ses.setCodeCachePath()` API for setting code cache directory. [#&#8203;33285](electron/electron#33285) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33286))</span>

#### Fixes

-   Fire 'show' event when a BrowserWindow is shown via maximize(). [#&#8203;33213](electron/electron#33213) <span style="font-size:small;">(Also in [16](electron/electron#33212), [18](https://github.com/electron/electron/pull/33214))</span>
-   Fixed a network service crash that could occur when using setCertificateVerifyProc. [#&#8203;33254](electron/electron#33254) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33253))</span>
-   Fixed an issue where BrowserView layout bounds where limited to it's visible bounds. [#&#8203;33398](electron/electron#33398) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33399))</span>
-   Fixed an issue where Chrome DevTools settings didn't persist between loads. [#&#8203;33273](electron/electron#33273) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33206))</span>
-   Fixed an issue where clicking "Open in Containing Folder" in the Sources tab in Devtools caused a crash. [#&#8203;33196](electron/electron#33196) <span style="font-size:small;">(Also in [16](electron/electron#33313), [18](https://github.com/electron/electron/pull/33197))</span>
-   Fixed broken event loop in renderer process when process reuse is enabled on windows platform. [#&#8203;33362](electron/electron#33362) <span style="font-size:small;">(Also in [16](electron/electron#33363), [18](https://github.com/electron/electron/pull/33361))</span>
-   Fixed crash in the render process on reload with pending node fs.promises. [#&#8203;33335](electron/electron#33335) <span style="font-size:small;">(Also in [15](electron/electron#33300), [16](electron/electron#33301), [18](https://github.com/electron/electron/pull/33302))</span>
-   Fixed drag regions on WCO windows on Windows. [#&#8203;33201](electron/electron#33201) <span style="font-size:small;">(Also in [15](electron/electron#33199), [16](electron/electron#33200), [18](https://github.com/electron/electron/pull/33202))</span>
-   Fixed incorrect external memory allocation tracking in nativeImage module. [#&#8203;33306](electron/electron#33306) <span style="font-size:small;">(Also in [15](electron/electron#33311), [16](electron/electron#33312), [18](https://github.com/electron/electron/pull/33305))</span>
-   Theoretical fix for a crash we're seeing when closing multiple child windows at the same time on macOS. [#&#8203;33283](electron/electron#33283) <span style="font-size:small;">(Also in [18](https://github.com/electron/electron/pull/33284))</span>

#### Other Changes

-   Fixed an issue where adding/removing display changes the BrowserWindow size. [#&#8203;33251](electron/electron#33251) <span style="font-size:small;">(Also in [14](electron/electron#33247), [15](electron/electron#33248), [16](electron/electron#33249), [18](https://github.com/electron/electron/pull/33250))</span>
-   Fixed an issue where moving a window created in a scaled display to a regular display would increase the window size. [#&#8203;33231](electron/electron#33231)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/83
Co-authored-by: renovate <renovatebot@kolaente.de>
Co-committed-by: renovate <renovatebot@kolaente.de>
@trop trop bot added the merged/16-x-y label Mar 25, 2022
jkleinsc added a commit that referenced this pull request Mar 25, 2022
@trop @mlaurencin
@jkleinsc @patchup
chore: cherry-pick 1aa9b09 from chromium (#33381)
8873984 
* chore: cherry-pick 1aa9b09 from chromium (#33231)

* chore: cherry-pick 1aa9b09 from chromium

* chore: update patches

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>

* chore: update patches

Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
@trop trop bot removed the in-flight/16-x-y label Mar 25, 2022
@tsvetilian-ty tsvetilian-ty mentioned this pull request May 14, 2022
Closed
@BenMcLean BenMcLean mentioned this pull request May 15, 2022
Closed
@trop trop bot removed the in-flight/15-x-y label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
17-x-y backport-check-skip Skip trop's backport validity checking semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mlaurencin @zcbenz @jkleinsc