From 174a07c6e2d56ca2d632a5897213897e3fc92899 Mon Sep 17 00:00:00 2001 From: Milan Burda Date: Thu, 6 Jan 2022 03:22:37 +0100 Subject: [PATCH] fix: incorrect `skipTransformProcessType` option parsing in `win.setVisibleOnAllWorkspaces()` --- shell/browser/api/electron_api_base_window.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/shell/browser/api/electron_api_base_window.cc b/shell/browser/api/electron_api_base_window.cc index 6bbc442cce438..03c20ee0e760a 100644 --- a/shell/browser/api/electron_api_base_window.cc +++ b/shell/browser/api/electron_api_base_window.cc @@ -854,10 +854,10 @@ void BaseWindow::SetVisibleOnAllWorkspaces(bool visible, gin_helper::Dictionary options; bool visibleOnFullScreen = false; bool skipTransformProcessType = false; - args->GetNext(&options) && - options.Get("visibleOnFullScreen", &visibleOnFullScreen); - args->GetNext(&options) && - options.Get("skipTransformProcessType", &skipTransformProcessType); + if (args->GetNext(&options)) { + options.Get("visibleOnFullScreen", &visibleOnFullScreen); + options.Get("skipTransformProcessType", &skipTransformProcessType); + } return window_->SetVisibleOnAllWorkspaces(visible, visibleOnFullScreen, skipTransformProcessType); }