Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setContentProtection affects BrowserWindow frame #31832

Merged
merged 1 commit into from Nov 15, 2021
Merged

fix: setContentProtection affects BrowserWindow frame #31832

merged 1 commit into from Nov 15, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 15, 2021

Backport of #31768

See that PR for details.

Notes: Fixed window frame glitch when calling setContentProtection.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 15, 2021
@trop trop bot requested a review from deermichel November 15, 2021 09:52
@trop trop bot mentioned this pull request Nov 15, 2021
Merged
3 tasks
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Nov 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 15, 2021
@codebytere
Copy link
Member

Failure

chromium features window.open disables JavaScript when it is disabled on the parent window

not germane.

@codebytere codebytere merged commit e8ba44c into 16-x-y Nov 15, 2021
@codebytere codebytere deleted the trop/16-x-y-bp-fix-setcontentprotection-affects-browserwindow-frame-1636969914499 branch November 15, 2021 15:26
@release-clerk
Copy link

release-clerk bot commented Nov 15, 2021

Release Notes Persisted

Fixed window frame glitch when calling setContentProtection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deermichel deermichel deermichel approved these changes

Assignees
No one assigned
Labels
16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @deermichel