Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window ordering on mac #30066

Merged

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 9, 2021

Backport of #29857

See that PR for details.

Notes: fix key window status on mac when opening panels or using custom window switchers

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 9, 2021
@trop trop bot requested a review from deepak1556 July 9, 2021 20:38
@trop trop bot mentioned this pull request Jul 9, 2021
5 tasks
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 9, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 9, 2021
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "multiple windows inherit correct fullscreen state" test is failing on arm64 macOS.

@deepak1556
Copy link
Member

Failing tests are unrelated, merging.

@deepak1556 deepak1556 merged commit 39feb87 into 14-x-y Jul 12, 2021
@deepak1556 deepak1556 deleted the trop/14-x-y-bp-fix-window-ordering-on-mac-1625863119995 branch July 12, 2021 15:54
@release-clerk
Copy link

release-clerk bot commented Jul 12, 2021

Release Notes Persisted

fix key window status on mac when opening panels or using custom window switchers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants