Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webview should maximize on requestFullscreen #29989

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 2, 2021

Backport of #29952

See that PR for details.

Notes: Fix requestFullscreen inside webview does not make the element take fullscreen.

@trop trop bot requested a review from a team as a code owner July 2, 2021 00:56
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 2, 2021
@trop trop bot requested a review from zcbenz July 2, 2021 00:57
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 2, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 2, 2021
@jkleinsc jkleinsc merged commit 0f45cd6 into 14-x-y Jul 5, 2021
@jkleinsc jkleinsc deleted the trop/14-x-y-bp-fix-webview-should-maximize-on-requestfullscreen-1625187404811 branch July 5, 2021 16:28
@release-clerk
Copy link

release-clerk bot commented Jul 5, 2021

Release Notes Persisted

Fix requestFullscreen inside webview does not make the element take fullscreen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants