Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: child window alwaysOnTop level persistence #29957

Merged
merged 1 commit into from Jul 1, 2021

Conversation

codebytere
Copy link
Member

Backport of #29813.

See that PR for details.

Notes: Fixed an issue where the setAlwaysOnTop value would sometimes not be preserved for child windows on macOS.

@codebytere codebytere requested a review from a team June 30, 2021 16:13
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 30, 2021
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 30, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 30, 2021
@jkleinsc
Copy link
Contributor

jkleinsc commented Jul 1, 2021

Merging as CI failures are unrelated to PR change.

@jkleinsc jkleinsc merged commit 574bd21 into 12-x-y Jul 1, 2021
@jkleinsc jkleinsc deleted the window-on-top-persistence-12 branch July 1, 2021 15:51
@release-clerk
Copy link

release-clerk bot commented Jul 1, 2021

Release Notes Persisted

Fixed an issue where the setAlwaysOnTop value would sometimes not be preserved for child windows on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants