From fe8f4fb74c122374778bcf1f9b4ac48cfa45b4bb Mon Sep 17 00:00:00 2001 From: Jeremy Rose Date: Tue, 22 Jun 2021 13:13:41 -0700 Subject: [PATCH 1/2] fix: stop window.open from hanging when prevented --- lib/browser/guest-window-proxy.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/browser/guest-window-proxy.ts b/lib/browser/guest-window-proxy.ts index c8f91bfc43e6f..9a6aa1f576676 100644 --- a/lib/browser/guest-window-proxy.ts +++ b/lib/browser/guest-window-proxy.ts @@ -75,6 +75,7 @@ ipcMainInternal.on( const browserWindowOptions = (event.sender as any)._callWindowOpenHandler(event, url, frameName, features); if (event.defaultPrevented) { + event.returnValue = null; return; } const guest = openGuestWindow({ From 9dd0a1151115b17729fbf2fd0b7af3a443f5e2a1 Mon Sep 17 00:00:00 2001 From: Jeremy Rose Date: Wed, 23 Jun 2021 13:56:09 -0700 Subject: [PATCH 2/2] add test --- spec-main/guest-window-manager-spec.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/spec-main/guest-window-manager-spec.ts b/spec-main/guest-window-manager-spec.ts index 01f7914d86b26..5cba5eb8a3aa0 100644 --- a/spec-main/guest-window-manager-spec.ts +++ b/spec-main/guest-window-manager-spec.ts @@ -224,6 +224,12 @@ describe('webContents.setWindowOpenHandler', () => { browserWindow.webContents.executeJavaScript("window.open('about:blank') && true"); }); + + it('does not hang parent window when denying window.open', async () => { + browserWindow.webContents.setWindowOpenHandler(() => ({ action: 'deny' })); + browserWindow.webContents.executeJavaScript("window.open('https://127.0.0.1')"); + expect(await browserWindow.webContents.executeJavaScript('42')).to.equal(42); + }); }); } });