Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick ff0d013f60fa from chromium #29879

Merged
merged 2 commits into from Jun 29, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Jun 24, 2021

[86-LTS] Add AudioHandler to orphan handlers when context is suspended.

If the context is suspended, pulling of the audio graph is stopped.
But we still need to add the handler in this case so that when the
context is resumed, the handler is still alive until it can be safely
removed. Hence, we must still add the handler if the context is
suspended.

Test cases from issue 1176218 manually tested with no failures. Also
this doesn't cause any regressions in issue 1003807 and issue 1017961.
(Manually tested the test cases from those issues.)

(cherry picked from commit 4a38ea3f1f78e0a0ffc1464e227cee6c1f2fd90b)

Bug: 1176218
Change-Id: Icd927c488505dfee9ff716866f98286e286d546a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874771
Commit-Queue: Raymond Toy rtoy@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#881533}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2917093
Reviewed-by: Raymond Toy rtoy@chromium.org
Reviewed-by: Victor-Gabriel Savu vsavu@google.com
Commit-Queue: Jana Grill janagrill@google.com
Cr-Commit-Position: refs/branch-heads/4240@{#1648}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}

Notes: Security: backported fix for CVE-2021-30522.

@ppontes ppontes requested a review from a team as a code owner June 24, 2021 13:33
@ppontes ppontes added 11-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Jun 24, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jun 24, 2021
@jkleinsc jkleinsc merged commit bde63c1 into 11-x-y Jun 29, 2021
@jkleinsc jkleinsc deleted the cherry-pick/11-x-y/chromium/ff0d013f60fa branch June 29, 2021 20:08
@release-clerk
Copy link

release-clerk bot commented Jun 29, 2021

Release Notes Persisted

Security: backported fix for CVE-2021-30522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants