feat: remove BrowserWindow option inheritance #28550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
reviewed
Apr 9, 2021
miniak
approved these changes
Apr 9, 2021
jkleinsc
approved these changes
Apr 9, 2021
zcbenz
approved these changes
Apr 12, 2021
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/approved ✅
api-review/requested 🗳
labels
electron-cation
bot
added
api-review/requested 🗳
and removed
api-review/approved ✅
labels
|
Release Notes Persisted
|
5 tasks
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 30, 2021
Breaking change: electron/electron#28550 Child windows no longer inherit BrowserWindow construction options from their parents.
2 tasks
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 30, 2021
Breaking change: electron/electron#28550 Child windows no longer inherit BrowserWindow construction options from their parents.
2 tasks
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 5, 2021
Breaking change: electron/electron#28550 Child windows no longer inherit BrowserWindow construction options from their parents.
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 5, 2021
Breaking change: electron/electron#28550 Child windows no longer inherit BrowserWindow construction options from their parents.
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 10, 2021
Breaking change: electron/electron#28550 Child windows no longer inherit BrowserWindow construction options from their parents.
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 10, 2021
Breaking change: electron/electron#28550 Child windows no longer inherit BrowserWindow construction options from their parents.
PrestonN
pushed a commit
to FreeTubeApp/FreeTube
that referenced
this pull request
Nov 10, 2021
* ^ Update electron 13.x > 15.x * ! Fix child window options due to breaking change in electron 14.x Breaking change: electron/electron#28550 Child windows no longer inherit BrowserWindow construction options from their parents.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Removes the deprecated and not terribly useful 'feature' of inheriting
BrowserWindow options from parents on
window.open().Checklist
npm testpassesRelease Notes
Notes: Child windows no longer inherit BrowserWindow construction options from their parents.