Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated additionalFeatures #28548

Merged
merged 4 commits into from Apr 19, 2021
Merged

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Apr 6, 2021

Description of Change

This removes the deprecated additionalFeatures key from the new-window and
did-create-window events. It is retained in new-window as an argument but
will always be the empty array [], because that event uses positional
arguments.

The new behavior is that bare keys will end up as true in the options
argument.

Checklist

Release Notes

Notes: Removed deprecated additionalFeatures property from new-window and did-create-window WebContents events.

@nornagon nornagon added the semver/major incompatible API changes label Apr 6, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Apr 6, 2021
@nornagon
Copy link
Member Author

API review bot is broken. Merging as this has been approved.

@nornagon nornagon merged commit e12a3cb into master Apr 19, 2021
@release-clerk
Copy link

release-clerk bot commented Apr 19, 2021

Release Notes Persisted

Removed deprecated additionalFeatures property from new-window and did-create-window WebContents events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants