Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add process.contextId used by @electron/remote #28007

Merged
merged 2 commits into from Mar 17, 2021
Merged

feat: add process.contextId used by @electron/remote #28007

merged 2 commits into from Mar 17, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 4, 2021 •
edited

Description of Change

The built-in remote module is usable in sandboxed renderers. However the standalone https://github.com/electron/remote version is not due to process._linkedBinding not being available to the preload script. Expose public API for that.

Checklist

Release Notes

Notes: Added process.contextId used by @electron/remote.

@miniak miniak added semver/minor backwards-compatible functionality target/13-x-y labels Mar 4, 2021
@miniak miniak requested a review from nornagon March 4, 2021 20:48
@miniak miniak self-assigned this Mar 4, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Mar 4, 2021
@miniak miniak force-pushed the miniak/process-context-id branch from faadf85 to 848c123 Compare March 4, 2021 20:54
nornagon
nornagon reviewed Mar 4, 2021
View reviewed changes
docs/api/process.md Outdated Show resolved Hide resolved
nornagon
nornagon reviewed Mar 4, 2021
View reviewed changes
docs/api/process.md Outdated Show resolved Hide resolved
@miniak miniak force-pushed the miniak/process-context-id branch 2 times, most recently from 7890df4 to 9e9e1f3 Compare March 5, 2021 16:36
@miniak miniak force-pushed the miniak/process-context-id branch from 9e9e1f3 to cdcb0cd Compare March 5, 2021 17:24
@miniak miniak requested a review from nornagon March 5, 2021 18:13
@miniak @nornagon
Update docs/api/process.md
14639de 
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
@miniak miniak mentioned this pull request Mar 10, 2021
Merged
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 11, 2021
@nornagon nornagon merged commit 485fa5b into master Mar 17, 2021
@release-clerk
Copy link

release-clerk bot commented Mar 17, 2021

Release Notes Persisted

Added process.contextId used by @electron/remote.

@nornagon nornagon deleted the miniak/process-context-id branch March 17, 2021 18:23
@trop trop bot mentioned this pull request Mar 17, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Mar 17, 2021

I have automatically backported this PR to "13-x-y", please check out #28251

@trop trop bot removed the in-flight/13-x-y label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
api-review/requested 🗳 semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @nornagon @zcbenz @codebytere