Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid crashing in NativeViewHost::SetParentAccessible on Windows 10 #26952

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 11, 2020

Backport of #26924

See that PR for details.

Notes: Fixed an occasional crash on Windows related to NativeViewHost::SetParentAccessible.

This fixes #26905. The patch was obtained from @deepak1556, who in turn
got it from the Microsoft Teams folks.

I believe the crash started happening due to the changes in
https://chromium.googlesource.com/chromium/src.git/+/5c6c8e994bce2bfb867279ae5068e9f9134e70c3%5E!/#F15

This affects Electron 9 and later.

Notes: Fix occasional crash on Windows
@trop trop bot requested a review from a team as a code owner December 11, 2020 17:48
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 11, 2020
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Dec 11, 2020
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 11, 2020
@MarshallOfSound MarshallOfSound merged commit 3d01b83 into 12-x-y Dec 11, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 11, 2020

Release Notes Persisted

Fixed an occasional crash on Windows related to NativeViewHost::SetParentAccessible.

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants