Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renderer crash on setImmediate #26748

Merged
merged 1 commit into from Dec 1, 2020
Merged

fix: renderer crash on setImmediate #26748

merged 1 commit into from Dec 1, 2020

Conversation

codebytere
Copy link
Member

Backport of #26365.

See that PR for details.

Notes: Fixes an issue whereby a corrupted async_hooks stack would crash the renderer when throwing some errors in the renderer process.

@codebytere codebytere requested a review from a team December 1, 2020 01:38
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 1, 2020
@trop trop bot mentioned this pull request Dec 1, 2020
4 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Dec 1, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 1, 2020
@ckerr ckerr merged commit 738740f into 9-x-y Dec 1, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 1, 2020

Release Notes Persisted

Fixes an issue whereby a corrupted async_hooks stack would crash the renderer when throwing some errors in the renderer process.

@ckerr ckerr deleted the setimmediate-crash-9 branch December 1, 2020 21:44
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants