chore: cherry-pick daad98ce from chromium #26430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #26419 The "IsOS/IsAtLeastOS/IsAtMostOS" functions are driven from the Darwin version number, which is always accurate. Adjust the SysInfo::OperatingSystemVersionNumbers() function to return accurate version numbers (or the best we can deduce) so that all version numbers returned by helper functions are accurate and consistent. Bug: 1101439 Bug: 1108832 Change-Id: I2ca92478d76bf572cc55875cba443f4978482d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315490 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791491}
nornagon
approved these changes
Nov 10, 2020
jkleinsc
approved these changes
Nov 11, 2020
|
Release Notes Persisted
|
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #26419
The "IsOS/IsAtLeastOS/IsAtMostOS" functions are driven from the Darwin
version number, which is always accurate. Adjust the
SysInfo::OperatingSystemVersionNumbers() function to return accurate
version numbers (or the best we can deduce) so that all version
numbers returned by helper functions are accurate and consistent.
Change-Id: I2ca92478d76bf572cc55875cba443f4978482d10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315490
Checklist
npm testpassesRelease Notes
Notes: Fixed value of
getSystemVersion()on Big Sur