Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call node::Stop on exit #25502

Merged
merged 1 commit into from Sep 17, 2020
Merged

fix: call node::Stop on exit #25502

merged 1 commit into from Sep 17, 2020

Conversation

nornagon
Copy link
Member

Backport of #25430.

Notes: Fixed an issue that could cause a normally-exiting process to fail with an "illegal access" message and exit code 7.

@nornagon nornagon added the 9-x-y label Sep 16, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 16, 2020
@trop trop bot mentioned this pull request Sep 16, 2020
Merged
5 tasks
@trop trop bot added the backport This is a backport PR label Sep 16, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 16, 2020
@zcbenz zcbenz merged commit 489aafc into 9-x-y Sep 17, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 17, 2020

Release Notes Persisted

Fixed an issue that could cause a normally-exiting process to fail with an "illegal access" message and exit code 7.

@zcbenz zcbenz deleted the backport/9-x-y/node-stop branch September 17, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @zcbenz