fix: call node::Stop on exit #25501

nornagon · 2020-09-16T21:53:15Z

Backport of #25430.

Notes: Fixed an issue that could cause a normally-exiting process to fail with an "illegal access" message and exit code 7.

zcbenz · 2020-09-17T00:40:20Z

shell/app/node_main.cc

@@ -153,6 +153,7 @@ int NodeMain(int argc, char* argv[]) {

    exit_code = node::EmitExit(env);
    env->set_can_call_into_js(false);


Does this line need to be removed?

it's redundant, but it doesn't hurt to remove it.

release-clerk · 2020-09-17T02:32:15Z

Release Notes Persisted

Fixed an issue that could cause a normally-exiting process to fail with an "illegal access" message and exit code 7.

fix: call node::Stop on exit (#25430)

d3e3268

nornagon added the 8-x-y label Sep 16, 2020

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 16, 2020

trop bot mentioned this pull request Sep 16, 2020

fix: call node::Stop on exit #25430

Merged

5 tasks

trop bot added the backport This is a backport PR label Sep 16, 2020

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 16, 2020

zcbenz reviewed Sep 17, 2020

View reviewed changes

Update node_main.cc

8e57a60

zcbenz approved these changes Sep 17, 2020

View reviewed changes

codebytere merged commit afe59c5 into 8-x-y Sep 17, 2020

codebytere deleted the backport/8-x-y/node-stop branch September 17, 2020 02:32

Provide feedback

		@@ -153,6 +153,7 @@ int NodeMain(int argc, char* argv[]) {

		exit_code = node::EmitExit(env);
		env->set_can_call_into_js(false);