From d3f6a41487683770c3e3284532958d79451a7977 Mon Sep 17 00:00:00 2001 From: Deepak Mohan Date: Mon, 21 Oct 2019 15:15:27 -0700 Subject: [PATCH 1/2] chore: update build_bring_back_node_with_ltcg_configuration.patch set default value for node_with_ltcg=true --- ...uild_bring_back_node_with_ltcg_configuration.patch | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/patches/node/build_bring_back_node_with_ltcg_configuration.patch b/patches/node/build_bring_back_node_with_ltcg_configuration.patch index 24fb0cd6e28d0..859b76ed33396 100644 --- a/patches/node/build_bring_back_node_with_ltcg_configuration.patch +++ b/patches/node/build_bring_back_node_with_ltcg_configuration.patch @@ -10,9 +10,18 @@ THe fix for this should land in node-gyp as discussed in above issue, landing this as temporary patch. diff --git a/common.gypi b/common.gypi -index f07e65f719a1a5939997dfcae7bc787ee6391f4d..69b5439a5c19230e5568450c3aca9ce27661d77c 100644 +index bde7d7300f44596abe5cdfac0639ecb1bb4d885f..85fda5d97c6cb7257f1ffc14ec8dbe3cc68b51cb 100644 --- a/common.gypi +++ b/common.gypi +@@ -19,7 +19,7 @@ + 'node_use_v8_platform%': 'true', + 'node_use_bundled_v8%': 'true', + 'node_module_version%': '', +- 'node_with_ltcg%': '', ++ 'node_with_ltcg%': 'true', + 'node_shared_openssl%': 'false', + + 'node_tag%': '', @@ -180,6 +180,26 @@ 'cflags': [ '-fPIE' ], 'ldflags': [ '-fPIE', '-pie' ] From 56750ea9bcb90edf92c52b7ed767613c092906e7 Mon Sep 17 00:00:00 2001 From: Deepak Mohan Date: Tue, 22 Oct 2019 15:33:36 -0700 Subject: [PATCH 2/2] fix: move ltcg definition to Release configuration --- .../node/build_bring_back_node_with_ltcg_configuration.patch | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/patches/node/build_bring_back_node_with_ltcg_configuration.patch b/patches/node/build_bring_back_node_with_ltcg_configuration.patch index 859b76ed33396..ff48f6394a2f7 100644 --- a/patches/node/build_bring_back_node_with_ltcg_configuration.patch +++ b/patches/node/build_bring_back_node_with_ltcg_configuration.patch @@ -10,7 +10,7 @@ THe fix for this should land in node-gyp as discussed in above issue, landing this as temporary patch. diff --git a/common.gypi b/common.gypi -index bde7d7300f44596abe5cdfac0639ecb1bb4d885f..85fda5d97c6cb7257f1ffc14ec8dbe3cc68b51cb 100644 +index bde7d7300f44596abe5cdfac0639ecb1bb4d885f..412f613e7cfcf563fa6a000b932723166ab567da 100644 --- a/common.gypi +++ b/common.gypi @@ -19,7 +19,7 @@ @@ -22,7 +22,7 @@ index bde7d7300f44596abe5cdfac0639ecb1bb4d885f..85fda5d97c6cb7257f1ffc14ec8dbe3c 'node_shared_openssl%': 'false', 'node_tag%': '', -@@ -180,6 +180,26 @@ +@@ -240,6 +240,26 @@ 'cflags': [ '-fPIE' ], 'ldflags': [ '-fPIE', '-pie' ] }],