Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: "maximize" implies "show", ready-to-show only on hidden window #8861

Closed
TanninOne opened this issue Mar 8, 2017 · 2 comments
Closed

Documentation: "maximize" implies "show", ready-to-show only on hidden window #8861

TanninOne opened this issue Mar 8, 2017 · 2 comments
Assignees
@zeke
Labels
documentation 📓

Comments

@TanninOne
Copy link
Contributor

  • Electron version: 1.4.14
  • Operating system: Windows

This isn't much of a bug report but I think the documentation could be a bit clearer on a few things:

  • When you call the "maximize" function on a BrowserWindow that was created with "show: false" it shows the window
  • The "ready-to-show" event is only invoked if the BrowserWindow is not shown yet (so it was started with show: false and no "show" or "maximize" were called on it before). The documentation just says

While loading the page, the ready-to-show event will be emitted when renderer process has done drawing for the first time
@zeke zeke self-assigned this Mar 8, 2017
@zeke
Copy link
Contributor

zeke commented Mar 8, 2017

Good catch, @TanninOne. Would be willing to open a PR that updates these docs?

TanninOne added a commit to TanninOne/electron that referenced this issue Mar 9, 2017
@TanninOne
Update browser-window.md
410e806 
Notes that maximize will also show the window and that ready-to-show won't fire if the window is already being displayed. (See issue electron#8861)
@TanninOne TanninOne mentioned this issue Mar 9, 2017
Merged
@pushkin- pushkin- mentioned this issue Jun 28, 2019
Closed
@danny-does-stuff
Copy link

For anyone with the same problem as me, something similar happens when calling browserWindow.hide. The issue is documented here #24855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeke zeke

Labels
documentation 📓
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zeke @TanninOne @danny-does-stuff